From 5c69335a7840374a60949c5ddc6a8c3058c375ca Mon Sep 17 00:00:00 2001
From: Victor Trinh <victor.trinh@gsoft.com>
Date: Mon, 23 Dec 2024 11:39:35 -0500
Subject: [PATCH] [DS-515] Add required examples with nece

---
 .changeset/gentle-monkeys-admire.md                       | 5 +++++
 apps/docs/content/components/content/Label.mdx            | 8 ++++++--
 apps/docs/examples/Preview.ts                             | 7 +++++--
 .../components/src/typography/Label/docs/required1.tsx    | 7 +++++++
 .../typography/Label/docs/{required.tsx => required2.tsx} | 2 +-
 packages/components/src/typography/Label/src/Label.tsx    | 2 +-
 6 files changed, 25 insertions(+), 6 deletions(-)
 create mode 100644 .changeset/gentle-monkeys-admire.md
 create mode 100644 packages/components/src/typography/Label/docs/required1.tsx
 rename packages/components/src/typography/Label/docs/{required.tsx => required2.tsx} (60%)

diff --git a/.changeset/gentle-monkeys-admire.md b/.changeset/gentle-monkeys-admire.md
new file mode 100644
index 000000000..61c149ad8
--- /dev/null
+++ b/.changeset/gentle-monkeys-admire.md
@@ -0,0 +1,5 @@
+---
+"@hopper-ui/components": patch
+---
+
+Fix necessityIndicator not appearing when it's a label
diff --git a/apps/docs/content/components/content/Label.mdx b/apps/docs/content/components/content/Label.mdx
index cb0124587..1bf467b35 100644
--- a/apps/docs/content/components/content/Label.mdx
+++ b/apps/docs/content/components/content/Label.mdx
@@ -35,9 +35,13 @@ The label component has a default color, but it can be easily overridden.
 <Example src="typography/Label/docs/color" />
 
 ### Required
-The label component can be marked as required.
+The label component can be marked as required. You can customize the necessity indicator, such as using an asterisk.
 
-<Example src="typography/Label/docs/required" />
+<Example src="typography/Label/docs/required1" />
+
+Or a label.
+
+<Example src="typography/Label/docs/required2" />
 
 <FeatureFlag flag="next">
     ## Advanced customization
diff --git a/apps/docs/examples/Preview.ts b/apps/docs/examples/Preview.ts
index 4447d41c4..2de42c2a9 100644
--- a/apps/docs/examples/Preview.ts
+++ b/apps/docs/examples/Preview.ts
@@ -407,8 +407,11 @@ export const Previews: Record<string, Preview> = {
     "typography/Label/docs/color": {
         component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/color.tsx"))
     },
-    "typography/Label/docs/required": {
-        component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/required.tsx"))
+    "typography/Label/docs/required1": {
+        component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/required1.tsx"))
+    },
+    "typography/Label/docs/required2": {
+        component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/required2.tsx"))
     },
     "typography/Label/docs/advancedCustomization": {
         component: lazy(() => import("@/../../packages/components/src/typography/Label/docs/advancedCustomization.tsx"))
diff --git a/packages/components/src/typography/Label/docs/required1.tsx b/packages/components/src/typography/Label/docs/required1.tsx
new file mode 100644
index 000000000..44a75f62a
--- /dev/null
+++ b/packages/components/src/typography/Label/docs/required1.tsx
@@ -0,0 +1,7 @@
+import { Label } from "@hopper-ui/components";
+
+export default function Example() {
+    return (
+        <Label isRequired necessityIndicator="asterisk">Username</Label>
+    );
+}
diff --git a/packages/components/src/typography/Label/docs/required.tsx b/packages/components/src/typography/Label/docs/required2.tsx
similarity index 60%
rename from packages/components/src/typography/Label/docs/required.tsx
rename to packages/components/src/typography/Label/docs/required2.tsx
index 3c6d370b4..60a97bcd2 100644
--- a/packages/components/src/typography/Label/docs/required.tsx
+++ b/packages/components/src/typography/Label/docs/required2.tsx
@@ -2,6 +2,6 @@ import { Label } from "@hopper-ui/components";
 
 export default function Example() {
     return (
-        <Label isRequired>Username</Label>
+        <Label isRequired necessityIndicator="label">Username</Label>
     );
 }
diff --git a/packages/components/src/typography/Label/src/Label.tsx b/packages/components/src/typography/Label/src/Label.tsx
index 111c07513..d92d7e798 100644
--- a/packages/components/src/typography/Label/src/Label.tsx
+++ b/packages/components/src/typography/Label/src/Label.tsx
@@ -79,7 +79,7 @@ function Label(props: LabelProps, ref: ForwardedRef<HTMLLabelElement>) {
             {...filteredProps}
         >
             {children}
-            {(necessityIndicator === "label" && !isRequired) && <span className={styles["hop-Label__label-indicator"]}> ({necessityLabel})</span>}
+            {necessityIndicator === "label" && isRequired && <span className={styles["hop-Label__label-indicator"]}> ({necessityLabel})</span>}
             {necessityIndicator === "asterisk" && isRequired && requiredIndicator}
         </RACLabel>
     );