Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect input pressure units for the Python refraction models #5

Open
AdamRJensen opened this issue Nov 28, 2024 · 1 comment
Open

Incorrect input pressure units for the Python refraction models #5

AdamRJensen opened this issue Nov 28, 2024 · 1 comment

Comments

@AdamRJensen
Copy link

For the refraction models in the Python package, I think the units should be hPa as reported in the paper and not Pa as shown in the documentation.
https://github.com/gschwind/sg2/blob/ca99a3ac35454ae85a4b2ec02c231c5bdebf2aa3/python/pysg2.cxx#L1046-L047

The Python functions are sg2.topocentric_correction_refraction_SAE and sg2.topocentric_correction_refraction_ZIM.

ICYMI @IoannisSifnaios and @kandersolar
@gschwind
Copy link
Owner

Thank you for your feedback, I will have a look.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gschwind @AdamRJensen