From c042b8a1e84109d8690659d338779d3894cf1f43 Mon Sep 17 00:00:00 2001 From: Rob Morgan Date: Thu, 2 Apr 2020 15:20:18 +0200 Subject: [PATCH 1/2] fixes #52. ensure the NAT references the private subnetwork --- modules/vpc-network/main.tf | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/vpc-network/main.tf b/modules/vpc-network/main.tf index d1da41f..5fb26b2 100644 --- a/modules/vpc-network/main.tf +++ b/modules/vpc-network/main.tf @@ -69,7 +69,7 @@ resource "google_compute_router_nat" "vpc_nat" { source_subnetwork_ip_ranges_to_nat = "LIST_OF_SUBNETWORKS" subnetwork { - name = google_compute_subnetwork.vpc_subnetwork_public.self_link + name = google_compute_subnetwork.vpc_subnetwork_private.self_link source_ip_ranges_to_nat = ["ALL_IP_RANGES"] } } @@ -120,4 +120,3 @@ module "network_firewall" { public_subnetwork = google_compute_subnetwork.vpc_subnetwork_public.self_link private_subnetwork = google_compute_subnetwork.vpc_subnetwork_private.self_link } - From 40b02b35c8bb1bfa221743c3095edb1f5faa74eb Mon Sep 17 00:00:00 2001 From: Rob Morgan Date: Thu, 2 Apr 2020 15:25:26 +0200 Subject: [PATCH 2/2] lock python pkg --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 3f7c529..ccea4b8 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -47,7 +47,7 @@ jobs: # Fail the build if the pre-commit hooks don't pass. Note: if you run pre-commit install locally, these hooks will # execute automatically every time before you commit, ensuring the build never fails at this step! - - run: pip install pre-commit==1.11.2 + - run: pip install pre-commit==1.11.2 cfgv==2.0.1 - run: pre-commit install - run: pre-commit run --all-files