Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate sources of non-determinism #5

Open
grtlr opened this issue Jan 14, 2025 · 0 comments
Open

Investigate sources of non-determinism #5

grtlr opened this issue Jan 14, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@grtlr
Copy link
Owner

grtlr commented Jan 14, 2025

For some reason, the layout does not seem to be deterministic across platforms.

  • Results on WASM look different than on native.
  • @teh-cmc reported flaky tests on Linux.
@grtlr grtlr added the bug Something isn't working label Jan 14, 2025
@grtlr grtlr mentioned this issue Jan 14, 2025
Merged
teh-cmc added a commit to rerun-io/rerun that referenced this issue Jan 14, 2025
@grtlr @teh-cmc
Fix flaky re_graph_view test by removing dynamically-placed node (#…
b2b7f91 
…8683)

### What

Title.

The downside of this is that we now skip the actual layout algorithm
entirely, as all nodes are placed at fixed positions.

I somehow need to figure out where the determinism in `fjadra` is coming
from:
* grtlr/fjadra#5
<!--
Make sure the PR title and labels are set to maximize their usefulness
for the CHANGELOG,
and our `git log`.

If you have noticed any breaking changes, include them in the migration
guide.

We track various metrics at <https://build.rerun.io>.

For maintainers:
* To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
* To deploy documentation changes immediately after merging this PR, add
the `deploy docs` label.
-->

---------

Co-authored-by: Clement Rey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grtlr