Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Feature flags only update with a restart #16

Closed
august-growthbook opened this issue Sep 13, 2023 · 4 comments
Closed

[Bug] Feature flags only update with a restart #16

august-growthbook opened this issue Sep 13, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@august-growthbook
Copy link

august-growthbook commented Sep 13, 2023

Summary

From the user:

Feature flags don't update on GraphiQL. A restart is required for the changes to reflect.
Is it because of caching? What could be the potential solution here?

Expected Behavior

Feature flags should update without a restart.

Current Behavior

Feature flags update only with a restart.

More info

https://growthbookusers.slack.com/archives/C01T6PKD9C3/p1694505434135549

@august-growthbook august-growthbook added the bug Something isn't working label Sep 13, 2023
@ian-ross
Copy link
Collaborator

ian-ross commented Sep 16, 2023

There was a bug in the SSE library I use for getting streaming updates from GrowthBook (this issue: r3labs/sse#147). This meant that an SSE connection dropped by the GrowthBook server was not reconnected properly. SSE client connections should deal with reconnection transparently, so this was a bug. There's no way for a server to know when the client at the other end of an SSE connection is still there, apart from waiting for the relevant TCP timeouts, so it's pretty normal to drop the connection on the server side periodically and to expect the client to reconnect. The GrowthBook server does this, but the bug in the SSE package I'm using prevented clean reconnection, so SSE updates appeared to stop coming.

I've now forked the dependency and fixed the problem (using an existing PR that's open on that package). Streaming updates now appear to be delivered indefinitely, and the connection to the server is re-established immediately each time that it's dropped.

This fix is in v0.1.7 of the SDK.

@ian-ross
Copy link
Collaborator

ian-ross commented Sep 16, 2023

Closing as fixed in v0.1.7.

@august-growthbook
Copy link
Author

Thank you so much, Ian! I'll let the customer who reported this know. We really appreciate how quickly you were able to resolve this!

@darkLord19
Copy link

@ian-ross @august-growthbook thanks a lot for quick fix. I will integrate latest version in our code and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants