Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box with no props and only one child can be removed #45

Open
taysea opened this issue Jun 2, 2023 · 0 comments
Open

Box with no props and only one child can be removed #45

taysea opened this issue Jun 2, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@taysea
Copy link
Collaborator

taysea commented Jun 2, 2023

Please describe what the rule should do:

If a Box has no props on it and only has one child, suggest to remove the Box all together.

For example:

<Box>
   <Button label="Hello" />
</Box>

This falls into best practices for clean code/removing unnecessary divs from DOM.

What category of rule is this? (place an "X" next to just one item)

[ ] Warns about a potential error (problem)
[x] Suggests an alternate way of doing something (suggestion)
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

Why should this rule be included in eslint-plugin-grommet?

@taysea taysea added the enhancement New feature or request label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant