Adding or removing users can cause a 503 error

[RaywanS]

Hi team,

I have noticed an issue while adding/removing users (both at site level and folder level).

Basically, I just add (or remove) one or multiple users and click on "Confirm". As it take forevers (average of 10 seconds), my natural behavior is to click again few times on the Confirm button, which often leads to longer waiting time and then a 503 error, as seen on the screenshot.

We were able to reproduce it with @fflorent

[RaywanS]

PS : this screenshot doesn't show the 503 error but most of the time, it displays it in the error box

[vviers]

Idea : deactivate the "Confirm" button when a request is already going on ?

[hexaltation]

May be linked with #1005

[fflorent]

@manuhabitela suggests that disabling the button while the request is in progress may not be a great idea for the accessibility. Maybe notifying after 2 seconds that the request is in progress instead.

[manuhabitela]

Yeah, without giving it special thoughts, just setting disabled on a button after clicking it can cause issues with keyboard users/screen readers. For example, focus can go poof and go back to the very top of the body tag, because focus was on something that doesn't exist anymore in the "tabbable" element list.

We could virtually disable the button, but not having it actually disabled in the DOM, but making sure clicking doesn't trigger any action. We can take some inspiration from react-aria "pending buttons" for such cases: https://react-spectrum.adobe.com/react-aria/Button.html#pending