Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling changes linked to document conversion #1289

Open
lusebille opened this issue Oct 31, 2024 · 1 comment
Open

Styling changes linked to document conversion #1289

lusebille opened this issue Oct 31, 2024 · 1 comment

Comments

@lusebille
Copy link
Collaborator

lusebille commented Oct 31, 2024

Linked to #1015

As everything is explained on figma https://www.figma.com/design/wcpetFt6aOKzTszcvPPWLQ/%5B05%2F24%5D-Grist-Design?node-id=559-80548&t=qX4iHFYd8uzsW8kZ-1, some styling adjustments are needed and due to this new user journey.

  1. Adjust width of the container > up to 750px to make sure all content is readable in all languages (today it's not okay, content is 'jumping' to the next line

  2. SELECTION POPUP : Make the blocks in the selection popup more accessible and have a coherent design :

  • 1° put the same radio button everywhere ( the rounded one , not the 'check' sign one ), today they're different radio buttons used in Grist (look on figma link)
  • 2° Put a 2px 'light green' border for the selected block , today nothing apart the radio button indicates the selection
  • 3° Centered the radio button vertically into the block to make more efficient the all block is selected, not only the title
  • 4° Align 'cancel' and 'confirm' buttons on the right as it's more common and intuitive for user to click right down to validate
@fflorent
Copy link
Collaborator

A patch has been made by @hexaltation and is ready to be submitted in a PR when #1015 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Status: Ready to Dev
Development

No branches or pull requests

3 participants