-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Columns protected by access rules can be deleted by any user. #1272
Comments
A first step recommended when locking down parts of a document is to deny most users the permission to change structure: https://support.getgrist.com/access-rules/#lock-down-structure. This is not the default for compatibility with documents without access rules. Locking down structure will prevent actions like deleting columns. That said, I agree that denying "Update" permission on a table or column should probably deny the ability to delete that table/column as well. At least I don't see any argument against that. As for a simplified toggle, the issue that always comes up with simplified UI ideas is that they don't include the ability to specify who should have that permission. For example, important documents often match users with some in-document data using user attributes, and then control permissions using some data associated with the document (organization role, department, etc) |
I haven't allowed structure editing (See screenshot below) The ProblemThe problem with this structure permission deny approach (For my use case) is that I do want people to be able to create and delete tables and columns, to work with the structure... But then I want to lock down columns or tables that I don't want to be delete-able anymore. My GoalI want the crowd (people with public access to the grist doc link, that don't need to sign-up) to be able to make new tables add and remove columns they make by mistake, etc. But then owners/editors/moderators (people with accounts) to be able to restrict columns or whole tables form being deleted once they're ready, while still allowing public users to update the content of cells. Deny update should deny delete by defaultNaturally yes, you would expect that denying update permission would automatically deny delete. Possible SolutionsMore granular permissions will probably help cover a wider set of use cases. For example, I imagine if one had separate permissions for R, U & D per column then I could deny public users from deleting columns or tables, but they would still be able to update data in the cells of that column or create new columns. Let me know if there is actually a way to do this. Because I did some more testing and I don't see a way. This is what I found: More Delete issuesI created a test table using the owner account then locked it with the following permissions: I also found, A public user with read only permission is also able to edit column descriptions and this probably shouldn't be allowed. ###Structure permission Questions I'm happy to set a time/meeting to figure this all out if need be.
I imagine being logged in as the owner or an editor with permissions, them having that permission toggle be visible in column settings only to them. |
I've run into another issue now, where sometimes when I save access rules, I get logged out and also between sessions even though cookies/browser data aren't set to delete on browser exit. This is on Brave browser with adblocking and a VPN, but fingerprint blocking turned off. Should I open a separate issue? |
Current behavior
I have a crowd sourced table and one of the columns needs to be read only, which I managed to set-up fine.
The issue is, while public contributors can't delete the contents of the cells in that column, they can still delete the whole column and there doesn't appear to be a way to prevent that.
I need the protected column to be safe from deletion as it contains moderator verified links.
Additionally, if a public user deletes the column, they can't undo that action.
Here is the spreadsheet I'm working in.
Steps to reproduce
Setup access rules for a column as follows:
Using the following public access link:
Open the link in a separate browser and click the following button to delete a protected column
after doing so, the document undo button will not work
Describe the expected behavior
I expected that denying edit permission would naturally also deny deletion.
However this option can be added.
In the access rules there is only a RU (Read | Update) option for a column.
If there was also a Delete permission that would be intuitive.
Also I have an idea to make column access rules UI&UX much easier.
For logged in Owners, there could be toggles for these permissions right in the column settings sidebar:
Where have you encountered this bug?
The text was updated successfully, but these errors were encountered: