Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the "new" (?) xcontrol #2

Open
pierre-24 opened this issue Dec 13, 2019 · 2 comments
Open

Use the "new" (?) xcontrol #2

pierre-24 opened this issue Dec 13, 2019 · 2 comments
Labels
unlikely This issue describes a low-probability event in a distant future

Comments

@pierre-24
Copy link
Contributor

Describe the bug
I can imagine some of the reason that lead to the separation of xtb and xtb4stda, but it seems that the later still use the "old" input file format (and thus rely to command lines options for charge, solvent ...), while xtb allow to provide the additional informations in the input file ($chrg, $gbsa), which I find way more easier (for example, to automatically convert from output of other program, then running xtb4stda without having to know what the charge is).

Again, I guess that the reason this is not done yet (among other things like "not enough time") is that xcontrol provides a lot more options that only what is required here (which seems like a tuned single point), but that would definitely ease the life of the end user.

You could even imagine making the xcontrol part an external library shared between the two projects.

To Reproduce

Running xtb4stda on a file with $chrg 1 in it does not gives an error, but the charge is not considered (and thus the molecule is considered open-shell).

Expected behaviour
Charge (and other information) are considered.

Additional context
None.

@pierre-24 pierre-24 changed the title Use the new xcontrol Use the "new" (?) xcontrol Dec 13, 2019
@awvwgk
Copy link
Member

awvwgk commented Dec 14, 2019

There is an input format called set block here, which allows something like

$set
   charge 1
   uhf 2
$end

when append to a xyz or Turbomole coordinate file. The implementation is here:

xtb4stda/src/molbld.f

Lines 344 to 354 in f892525

if(index(line,'chrg ').ne.0.or.
. index(line,'charge ').ne.0)then
call readl(line,xx,nn)
ichrg=int(xx(1))
chrg =ichrg
endif
if(index(line,'uhf ').ne.0)then
call readl(line,xx,nn)
nalphabeta=int(xx(1))
spin =nalphabeta
endif

Considering the detailed input in xtb version 6, one might guess it evolved as replacement of the set block input format. But there are no plans for back ports from version 6 to this version 5 remnant.

@pierre-24
Copy link
Contributor Author

At least there is an input section to set some of those variables, which is what I wanted to know :)

@awvwgk awvwgk added the unlikely This issue describes a low-probability event in a distant future label May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unlikely This issue describes a low-probability event in a distant future
Projects
None yet
Development

No branches or pull requests

2 participants