Support GMP version 22.6 #1196
Open
Support GMP version 22.6 #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Files |
Conventional Commits Report
🚀 Conventional commits found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
+ Coverage 97.60% 97.78% +0.18%
==========================================
Files 65 71 +6
Lines 4544 4962 +418
Branches 825 894 +69
==========================================
+ Hits 4435 4852 +417
- Misses 74 75 +1
Partials 35 35 ☔ View full report in Codecov by Sentry. |
Implement support for GMP version 22.6 which adds audit reports, report configs and changes get feeds.
bjoernricks
force-pushed
the
support-gmp-v22.6
branch
from
d3fd59e to
22b65da
Compare
Support both new filter types.
The version is already encoded into the module name. For implementing a new protocol version it's easier when the version in not included in all test class names.
Not every XML element will have a value/text. Therefore it should be possible to set it optionally.
Extend GMP classed to support all report config commands.
jhelmold
reviewed
Jan 31, 2025
| b"</create_report_config>", | ||
| ) | ||
|
|
||
| self.gmp.clone_report_config(ReportFormatType.PDF) |
There was a problem hiding this comment.
Hello Björn, I am not sure if this test really makes sense, since there could be more than one report config for a report format. But I am not sure, what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Support GMP version 22.6
Why
Implement support for GMP version 22.6 which adds audit reports, report configs and changes get feeds.
References
https://jira.greenbone.net/browse/GEA-868
Closed #1195
Checklist
Also tested some report config request against gvmd manually.