Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: add ordinal compare to udp primitive types #207

Merged

Conversation

da2ce7
Copy link
Contributor

@da2ce7 da2ce7 commented Jul 15, 2024

@greatest-ape
Copy link
Owner

Thanks!

Could you please move the new trait implementations to the common.rs file, with each one under the corresponding struct?

@da2ce7 da2ce7 force-pushed the 20240715_udp_ordinal_compare branch from 9ead91c to a4c1bbf Compare July 15, 2024 18:26
@da2ce7
Copy link
Contributor Author

da2ce7 commented Jul 15, 2024

@greatest-ape done, all the trait implementations are now in the common.rs file.

@greatest-ape greatest-ape merged commit 62aab2d into greatest-ape:master Jul 16, 2024
3 of 4 checks passed
@greatest-ape
Copy link
Owner

Nice, thanks!

@da2ce7
Copy link
Contributor Author

da2ce7 commented Oct 31, 2024

@greatest-ape Thank You for merging. It has been a couple of months, can you please create a point release so that we can easily use this update in our project?

@greatest-ape
Copy link
Owner

greatest-ape commented Nov 22, 2024

A new release is currently kind of blocked on the failing CI, which is probably due to some change in GitHub workers no longer allowing io_uring use (?). Unfortunately, at the moment, I don’t have time to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ord and PartialOrd to the Udp Protocol primitive types.
2 participants