Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centerInViewport is not a function #3

Open
olbrich opened this issue Dec 23, 2009 · 5 comments
Open

centerInViewport is not a function #3

olbrich opened this issue Dec 23, 2009 · 5 comments

Comments

@olbrich
Copy link

olbrich commented Dec 23, 2009

in http://github.com/pilu/radiant-copy-move/commit/00ad9584c0fef5edeb89932c0b83d1a3ff85510a
the js was updated to use centerInViewport to center the dialog. This function does not exist in standard prototype or jQuery and thus breaks this plugin for anyone not using the custom library. This library this function is from needs to be explicitly added as a dependency or this change should be reverted.

@rca
Copy link

rca commented Feb 18, 2010

Just ran into this and had to use HEAD^ for it to work.

@smooshy
Copy link

smooshy commented Mar 12, 2010

I have the same problem. I believe I'm using HEAD but it still doesn't work. Any ideas?

@rurounijones
Copy link

I just installed from HEAD and same problem. Commenting out the offending line works but the result doesn't look great (It is usable though)

@rurounijones
Copy link

Of course, I am on 0.8 so just changing that line back to the old way works nicely. Maybe a 0.8 and 0.9 branch?

@rca
Copy link

rca commented Apr 5, 2010

After you clone the repo checkout commit 94a4f09 and you'll be all set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants