New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PatchTestOperation fails when patching float value #17

Closed

MateuszGravity9 opened this issue Jun 22, 2023 · 1 comment · Fixed by #52

Assignees

Labels

bug

Collaborator

MateuszGravity9 commented Jun 22, 2023 •

edited by BartekGravity

Loading

Issue copied from: java-json-tools#137

There seems to be an issue related to patching Float values in JsonNumEquals.

When patching a model with a Float value - the TestOperation value is deserialized to Double - and comparing a Double to a Float numEquals fails.

I've included a testcase, that shows the issue -> see TestFloatDoubleProblem.java
jsonpatch-issue.zip

Kindly regards.

MateuszGravity9 self-assigned this

MateuszGravity9 added the bug label

MateuszGravity9 linked a pull request

that will close this issue

17 patchtestoperation fails when patching float value #52

Merged

Collaborator Author

MateuszGravity9 commented Jul 3, 2023

Original issue java-json-tools#137

MateuszGravity9 closed this as completed in #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment