-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: readme corrections from localization #1933
Conversation
Preview is ready. |
Visual Tests Report is ready. |
@vvtimofeev preview is not support doc change lang |
@@ -336,8 +336,8 @@ LANDING_BLOCK--> | |||
|
|||
### Integration with routers | |||
|
|||
`Breadcrumbs` component accepts navigate function received from your router for performing a client side navigation programmatically. | |||
The following example shows the general pattern. | |||
The `Breadcrumbs` component accepts the navigation function received from your router for managing the client-side navigation in a software-based mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is software-based mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It means that some programs on the user side decide how to display breadcrumbs.
Are you sure that the original is correct?
programmatic | ˌprəʊɡrəˈmatɪk |
adjective
1 of the nature of or according to a programme, schedule, or method: a programmatic approach to change.
2 of the nature of programme music: programmatic tone poems and operas.
I can't get the idea. If you are sure, I will revert changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ValeraS please, find some time to respond.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's revert for now, this part of the readme will be removed in other PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted. Pls, check that it is good now.
|
||
### Интеграция с роутерами | ||
|
||
Компонент `Breadcrumbs` принимает функцию навигации от роутера для управления навигацией на стороне клиента в программном режиме. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Компонент `Breadcrumbs` принимает функцию навигации от роутера для управления навигацией на стороне клиента в программном режиме. | |
Компонент `Breadcrumbs` принимает функцию навигации от роутера для программного управления навигацией на стороне клиента. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied your suggestion, thx.
@amje @ogonkov @IsaevAlexandr @sofiushko @zamkovskaya @Arucard89 @korvin89 @DakEnviy @kseniya57 @Vladeeg @d3m1d0v @axtk @v4dyar4 if you don't mind, please find some time, to review my PR. |
…eyevvv/readme_corrections_from_loc_team
@amje rebased branch and fixed conflicts, if you don't mind, please merge it. |
Ok, friends, we plan to add ru loc to gravity-ui.com
So we did some edits in english readme files and added readme in Russian to every component, which present on gravity-ui.com
(Ticket: CLOUDLOC-2378)
If you don't mind, please review your component.