Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change behaviour of home/end in List #9

Closed
burashka opened this issue Apr 1, 2024 · 8 comments
Closed

Change behaviour of home/end in List #9

burashka opened this issue Apr 1, 2024 · 8 comments

Comments

@burashka
Copy link

burashka commented Apr 1, 2024

Objective

What is the problem and why is it important?

Keys home/end select first and last item in list. However, users expect change position of cursor in input.

May be, it's difference between MacOS and another system, because ctrl-arrow change position.

Solution Proposal

What should be done and how?

Сhange behaviour of home/end in List for non-macos users:

  • home/end will change position of cursor in input
  • ctrl-home/ctrl-end will select first and last item in list

May be, for all users?

Definition of done

What criteria should be met to consider the task complete?

List provides expected behaviour for home/end keys.

@resure resure moved this to Discussion in Gravity RFC Apr 5, 2024
@resure
Copy link
Contributor

resure commented Apr 5, 2024

@korvin89 @amje you might be interested

@korvin89
Copy link

korvin89 commented Apr 5, 2024

@resure We have already released new list component and don't have any plans for new features in old list.

@resure
Copy link
Contributor

resure commented Apr 5, 2024

@resure We have already released new list component and don't have any plans for new features in old list.

Well, what matters is not only the fact that a new component was released, but also the speed of adoption of that new component. If new List will be integrated into services as slowly as new calendar (1 to 3 years) then probably old List should be upgraded too so users won't suffer in the meanwhile.

@ogonkov
Copy link

ogonkov commented Apr 5, 2024

If focus inside list items Home/End should focus first/last item in list

@burashka
Copy link
Author

burashka commented Apr 5, 2024

@resure We have already released new list component and don't have any plans for new features in old list.

I see unstable branch in storybook. Can I use it now? When will new list component become stable and publish?

@korvin89
Copy link

korvin89 commented Apr 5, 2024

@burashka

home/end will change position of cursor in input

Yep, it is completely true according to w3c Combobox Pattern

ctrl-home/ctrl-end will select first and last item in list

There is no such keys behaviour pattern in w3c or or wherever, so our users will not be able to find out about such functionality in any way. I think we should not use patterns that are not standard.

Here my suggestion about your issue gravity-ui/uikit#1491.

@korvin89
Copy link

korvin89 commented Apr 5, 2024

@burashka

I see unstable branch in storybook. Can I use it now? When will new list component become stable and publish?

Yep, you can already use it, but component could have breaking changes in minors cause of in unstable status.

@amje
Copy link

amje commented May 6, 2024

@burashka @korvin89 I can see that feature is shipped to the current List, can we close this issue?

@amje amje closed this as completed May 7, 2024
@github-project-automation github-project-automation bot moved this from Discussion to Done in Gravity RFC May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants