Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table plugin to @gravity-ui/chartkit #8

Open
korvin89 opened this issue Mar 1, 2024 · 14 comments
Open

Add table plugin to @gravity-ui/chartkit #8

korvin89 opened this issue Mar 1, 2024 · 14 comments

Comments

@korvin89
Copy link

korvin89 commented Mar 1, 2024

Objective

Hi there! I'm from DataLens team and now we are using @gravity-ui/react-data-table solution to render tables in our application. It is a pretty powerful component but with restrictions in architecture for extending. We have a lack of core features like horizontal virtualization, sticky columns and convenient css api. Given the current architecture of the component, these improvements will require a complete rethink of the current code. This table is successfully used in many large applications, its code base is completely not covered by tests, so I consider it advisable not to make such serious changes to it.

Solution Proposal

I propose to organize the table plugin in chartkit lib based on tanstack table.

Why tanstack and not uikit table?

Uikit table is convenient for displaying a small amount of content in accordance with the Gravity UI design system, but it has big performance problems and also does not have the necessary functionality described above.

Definition of done

Chartkit lib should have the new plugin table for table visualisation.

@korvin89
Copy link
Author

korvin89 commented Mar 1, 2024

cc @kuzmadom @resure

@ma-efremoff
Copy link

sticky rows feature is present in @gravity-ui/react-data-table (headerData/footerData)

@korvin89
Copy link
Author

korvin89 commented Mar 5, 2024

sticky rows feature is present in @gravity-ui/react-data-table (headerData/footerData)

Are there any examples? It is a little bit unexpected behaviour from properties with such names :)

@ma-efremoff
Copy link

ma-efremoff commented Mar 5, 2024

Are there any examples?

https://preview.gravity-ui.com/react-data-table/?path=/story/react-data-table--default&args=fixHead:!true;fixFooter:!true

It is a little bit unexpected behaviour from properties with such names :)

It is a good time (cause of uikit6) to rename them, so if you know better names please file an issue to the repo.

Anyway, sticky rows is not the only feature missing in react-data-table.

@korvin89
Copy link
Author

korvin89 commented Mar 5, 2024

Are there any examples?

https://preview.gravity-ui.com/react-data-table/?path=/story/react-data-table--default&args=fixHead:!true;fixFooter:!true

It is a little bit unexpected behaviour from properties with such names :)

It is a good time (cause of uikit6) to rename them, so if you know better names please file an issue to the repo.

Anyway, sticky rows is not the only feature missing in react-data-table.

Wow! Thank you. I've fixed description.

@sareyu sareyu moved this to Discussion in Gravity RFC Mar 6, 2024
@refreakk
Copy link

Hello everyone! I might be off-topic, but perhaps it's time to update the @gravity-ui/react-data-table library to the new version of React? I really like the implementation of this particular table, but I can't use it in my projects.

I wouldn't mind participating in the update to the new version :)

@korvin89
Copy link
Author

Hello everyone! I might be off-topic, but perhaps it's time to update the @gravity-ui/react-data-table library to the new version of React? I really like the implementation of this particular table, but I can't use it in my projects.

I wouldn't mind participating in the update to the new version :)

You cannot use table with react 18?

@refreakk
Copy link

Hello everyone! I might be off-topic, but perhaps it's time to update the @gravity-ui/react-data-table library to the new version of React? I really like the implementation of this particular table, but I can't use it in my projects.
I wouldn't mind participating in the update to the new version :)

You cannot use table with react 18?

Yes, @gravity-ui/react-data-table support react 16.14.0 and down

@korvin89
Copy link
Author

korvin89 commented Mar 11, 2024

Yes, @gravity-ui/react-data-table support react 16.14.0 and down

And above >=16.14.0. So, there is no difficulties to use this table with react 17 | 18

@refreakk
Copy link

It really works. Thank you.

Two days ago it was showing errors on the React and React Dom versions, on vite.js.

@SeqviriouM
Copy link

@refreakk @korvin89 is this issue still relevant?

@korvin89
Copy link
Author

@refreakk @korvin89 is this issue still relevant?

Of course! It will take a lot of time I suppose

@resure
Copy link
Contributor

resure commented Apr 5, 2024

@korvin89 should we mark it as in progress then?

@korvin89
Copy link
Author

korvin89 commented Apr 5, 2024

@korvin89 should we mark it as in progress then?

Sure

@resure resure moved this from Discussion to In Progress in Gravity RFC Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

5 participants