-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table
plugin to @gravity-ui/chartkit
#8
Comments
|
Are there any examples? It is a little bit unexpected behaviour from properties with such names :) |
It is a good time (cause of uikit6) to rename them, so if you know better names please file an issue to the repo. Anyway, |
Wow! Thank you. I've fixed description. |
Hello everyone! I might be off-topic, but perhaps it's time to update the @gravity-ui/react-data-table library to the new version of React? I really like the implementation of this particular table, but I can't use it in my projects. I wouldn't mind participating in the update to the new version :) |
You cannot use table with react 18? |
Yes, @gravity-ui/react-data-table support react 16.14.0 and down |
And above >=16.14.0. So, there is no difficulties to use this table with react 17 | 18 |
It really works. Thank you. Two days ago it was showing errors on the React and React Dom versions, on vite.js. |
@korvin89 should we mark it as |
Sure |
Objective
Hi there! I'm from DataLens team and now we are using @gravity-ui/react-data-table solution to render tables in our application. It is a pretty powerful component but with restrictions in architecture for extending. We have a lack of core features like
horizontal virtualization
,sticky columns
and convenientcss api
. Given the current architecture of the component, these improvements will require a complete rethink of the current code. This table is successfully used in many large applications, its code base is completely not covered by tests, so I consider it advisable not to make such serious changes to it.Solution Proposal
I propose to organize the
table
plugin in chartkit lib based on tanstack table.Why tanstack and not uikit table?
Uikit table is convenient for displaying a small amount of content in accordance with the Gravity UI design system, but it has big performance problems and also does not have the necessary functionality described above.
Definition of done
Chartkit lib should have the new plugin
table
for table visualisation.The text was updated successfully, but these errors were encountered: