-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add warning on using non-uuid name for openssh nodes #50906
base: master
Are you sure you want to change the base?
Conversation
Amplify deployment status
|
docs/pages/enroll-resources/server-access/openssh/openssh-manual-install.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we fix the current error, then half of this warning seems moot. Can we instead make the wording in the section above more forceful about using a UUID?
Please see update for the name. |
docs/pages/enroll-resources/server-access/openssh/openssh-manual-install.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: rosstimothy <[email protected]>
Thanks, applied
…On Thu, Jan 9, 2025 at 10:58 AM rosstimothy ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
docs/pages/enroll-resources/server-access/openssh/openssh-manual-install.mdx
<#50906 (comment)>
:
> +The `metadata.name` field isn't mandatory, but setting it here will save you some work later. Using
+a non-UUID name can result in access errors when Teleport finds the node in its inventory.
Again, I don't think we should be too specific with our warning, as we may
very well be able to fix the current issue. I think we should instead put
stronger encouragement to use a UUID if users plan to populate this field
directl.
⬇️ Suggested change
-The `metadata.name` field isn't mandatory, but setting it here will save you some work later. Using
-a non-UUID name can result in access errors when Teleport finds the node in its inventory.
+The `metadata.name` field isn't mandatory, but if supplied, it must be a universal unique identifier (UUID). To generate a new UUID suitable for a `node` name
—
Reply to this email directly, view it on GitHub
<#50906 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOPERQJFKIYGAC37WF2TGWD2J2MCDAVCNFSM6AAAAABU4EDUJSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKNBQGMYTOMZQG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
docs/pages/enroll-resources/server-access/openssh/openssh-manual-install.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: rosstimothy <[email protected]>
Using a non-uuid can result in the web ui showing this on access attempts