Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ssh identity object #50787

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

fspmarshall
Copy link
Contributor

Adds an Identity object for ssh identities, intended to be roughly equivalent to tlsca.Identity. This PR includes the initial identity implementation, encoding/decoding to certs, and a rework of the cert issuance logic to accept the identity as a parameter. Future PRs will switch enforcement-side logic to use a parsed identity instead of passing around raw certs, and add a various related facilities to lib/decision.

Part of the ongoing PDP-related work (#49837).

@fspmarshall fspmarshall added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 backport/branch/v17 labels Jan 6, 2025
@fspmarshall fspmarshall force-pushed the fspmarshall/pdp-ssh-identity-rework-v2 branch from 8a39be2 to 5e667e3 Compare January 6, 2025 19:54
lib/sshca/identity.go Outdated Show resolved Hide resolved
lib/sshca/identity.go Outdated Show resolved Hide resolved
lib/sshca/identity.go Show resolved Hide resolved
lib/sshca/identity.go Show resolved Hide resolved
lib/sshca/identity_test.go Outdated Show resolved Hide resolved
lib/sshca/identity.go Outdated Show resolved Hide resolved
lib/sshca/identity.go Outdated Show resolved Hide resolved
lib/sshca/identity.go Outdated Show resolved Hide resolved
@fspmarshall fspmarshall force-pushed the fspmarshall/non-empty-testutil branch from e9a928e to e73e260 Compare January 7, 2025 16:17
Base automatically changed from fspmarshall/non-empty-testutil to master January 7, 2025 16:55
@fspmarshall fspmarshall force-pushed the fspmarshall/pdp-ssh-identity-rework-v2 branch 2 times, most recently from 1adcb75 to f8bb47f Compare January 9, 2025 18:25
@fspmarshall fspmarshall enabled auto-merge January 9, 2025 18:25
@fspmarshall fspmarshall force-pushed the fspmarshall/pdp-ssh-identity-rework-v2 branch from f8bb47f to fdb3980 Compare January 9, 2025 19:03
@fspmarshall fspmarshall force-pushed the fspmarshall/pdp-ssh-identity-rework-v2 branch from fdb3980 to 662db45 Compare January 9, 2025 22:11
@fspmarshall fspmarshall added this pull request to the merge queue Jan 9, 2025
Merged via the queue into master with commit a26c2a9 Jan 9, 2025
40 checks passed
@fspmarshall fspmarshall deleted the fspmarshall/pdp-ssh-identity-rework-v2 branch January 9, 2025 22:50
@public-teleport-github-review-bot

@fspmarshall See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Failed

fspmarshall added a commit that referenced this pull request Jan 9, 2025
fspmarshall added a commit that referenced this pull request Jan 9, 2025
fspmarshall added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants