-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ssh identity object #50787
Merged
Merged
add ssh identity object #50787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
backport/branch/v17
labels
Jan 6, 2025
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-identity-rework-v2
branch
from
January 6, 2025 19:54
8a39be2
to
5e667e3
Compare
rosstimothy
approved these changes
Jan 6, 2025
marcoandredinis
approved these changes
Jan 7, 2025
fspmarshall
force-pushed
the
fspmarshall/non-empty-testutil
branch
from
January 7, 2025 16:17
e9a928e
to
e73e260
Compare
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-identity-rework-v2
branch
2 times, most recently
from
January 9, 2025 18:25
1adcb75
to
f8bb47f
Compare
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-identity-rework-v2
branch
from
January 9, 2025 19:03
f8bb47f
to
fdb3980
Compare
fspmarshall
force-pushed
the
fspmarshall/pdp-ssh-identity-rework-v2
branch
from
January 9, 2025 22:11
fdb3980
to
662db45
Compare
@fspmarshall See the table below for backport results.
|
fspmarshall
added a commit
that referenced
this pull request
Jan 9, 2025
fspmarshall
added a commit
that referenced
this pull request
Jan 9, 2025
fspmarshall
added a commit
that referenced
this pull request
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v15
backport/branch/v16
backport/branch/v17
no-changelog
Indicates that a PR does not require a changelog entry
size/md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
Identity
object for ssh identities, intended to be roughly equivalent totlsca.Identity
. This PR includes the initial identity implementation, encoding/decoding to certs, and a rework of the cert issuance logic to accept the identity as a parameter. Future PRs will switch enforcement-side logic to use a parsed identity instead of passing around raw certs, and add a various related facilities tolib/decision
.Part of the ongoing PDP-related work (#49837).