Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could support attach video to spark reports? Many thanks! #24

Open
peizijune opened this issue Mar 13, 2023 · 4 comments
Open

Could support attach video to spark reports? Many thanks! #24

peizijune opened this issue Mar 13, 2023 · 4 comments

Comments

@peizijune
Copy link

someone already raised the point that now video attachment is still not supported by spark reports, but there is nobody raised this enhancement yet

please refer to: http://ghchirp.online/3196/
QQ20230313-160350@2x

many many thanks~

@grasshopper7
Copy link
Owner

Yeah I kinda forgot about it. Will have a look. Thanks

@grasshopper7
Copy link
Owner

Hi, I have had a look at this but the stumbling block is from the core extentreport code. The spark and html reports do not support any other attachment other than images.

A change will be needed to be made in that code base with a significant update with a PR. That code is not controlled by me.

Other is for me to fork it and put in the required changes. Though currently I am not sure how big the task is.

I will give it a try and lets see if it works.

@siva90144
Copy link

@grasshopper7 any update on this?

@grasshopper7
Copy link
Owner

grasshopper7 commented Aug 23, 2023

I have added a PR for this. If this is accepted by the owner then videos will be visible in the cucumber spark report also.
extent-framework/extentreports-java#400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants