Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme for renaming funtions #2

Open
pyrossh opened this issue Nov 4, 2015 · 1 comment
Open

Update readme for renaming funtions #2

pyrossh opened this issue Nov 4, 2015 · 1 comment

Comments

@pyrossh
Copy link
Contributor

pyrossh commented Nov 4, 2015

The docs/readme needs to be updated to specify that not all conventional input names follows graphql-relay js, Like the clientMutationId which is normally used in graphql-relay needs to be specified as clientMutationID graphql-relay-go.

Just updated my version to the latest.

I guess you need to update the blog post also?

@sogko
Copy link
Member

sogko commented Nov 4, 2015

Hi @pyros2097

Thanks for taking your time to look into this 👍🏻

Yeah you are right, the documentation is seriously lacking. I just updated the APIs for graphql-relay-go with the following changes

  • update the import path for graphql-go to github.com/chris-ramon/graphql and its new APIs
  • used golint suggestions for e.g. to use clientMutationID over clientMutationId.

I'll definitely would highlight the differences. My initial plan is to bring this library on par with graphql-relay-js v0.3.5 first (currently it is at v0.3.2). (Of course, I welcome PR contributions 😃)

Regarding the blog post, I've just updated it, thanks for the reminder! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants