Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:346 Error encoding arrays of custom scalars #379

Closed

Conversation

Vishal-Sikka
Copy link

@Vishal-Sikka Vishal-Sikka commented Sep 29, 2023

code has been adjusted to handle arrays of custom scalar types

fix: #346
/claim #346

when the scalar type is identified as UUID and the argument a is an array, each UUID in the array is individually encoded as a string within the GraphQL mutation. This should solve the issue of incorrect encoding for an array of UUID scalars
@aexol
Copy link
Collaborator

aexol commented Sep 29, 2023

No way, this is not the correct approach. You should not seek for the UUID but make it work for all the custom scalars with array

@Vishal-Sikka
Copy link
Author

No way, this is not the correct approach. You should not seek for the UUID but make it work for all the custom scalars with array

adjusted code to handle arrays of custom scalar types

@aexol
Copy link
Collaborator

aexol commented Oct 3, 2023

Ok, there is even no mock no nothing, so you are testing against schema which doesn't have the so called scalar? Closing

@aexol aexol closed this Oct 3, 2023
@Vishal-Sikka
Copy link
Author

Vishal-Sikka commented Oct 3, 2023

Ok, there is even no mock no nothing, so you are testing against schema which doesn't have the so called scalar? Closing

i have tested what user had issue with, i could have got more clarification if you have defined specific requirements, just read user's issue on #346 with point of view of some one is non graphql-zeus user , probably you should have create new issue with proper details

@akansh-bansal
Copy link

i want to pick it up @aexol could you clarify your requirements ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error encoding arrays of custom scalars
3 participants