Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If expiry was in epoch seconds, it may be out of the range of INT. #253

Open
koji-murata-spice opened this issue Feb 3, 2023 · 1 comment
Labels
needs triage Needs to be clasified by the mantiners

Comments

@koji-murata-spice
Copy link

Describe the bug

For description of the following file.
graphql_devise-0.17.1/lib/graphql_devise/types/credential_type.rb

field :expiry, Int, null: false
but when expiry is handled in epoch seconds, values after 2038/1/19 12:14:07 (2,147,483,647) are not available.

Also, even after applying the patch and changing the type of expiry to ID, it seems to cause a behavior problem in another place.
(I couldn't pinpoint the specific part that is adversely affected...)

Thank you in advance for your confirmation.

@koji-murata-spice koji-murata-spice added the needs triage Needs to be clasified by the mantiners label Feb 3, 2023
@00dav00
Copy link
Contributor

00dav00 commented Feb 6, 2023

Hi @koji-murata-spice , thanksr for message, this is an interesting insight. Do you have a project were this is replicated or the log of the error?
I'm not sure this is affecting a lot of people just yet, since this kind of tokens are short lived. For example the default expiration time for DTA is 2 weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Needs to be clasified by the mantiners
Projects
None yet
Development

No branches or pull requests

2 participants