Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent,common: lower the default parameters for query fee claiming #893

Conversation

cwtaras
Copy link
Member

@cwtaras cwtaras commented May 10, 2024

No description provided.

@cwtaras cwtaras marked this pull request as ready for review May 10, 2024 07:58
@cwtaras cwtaras force-pushed the bugra/query-fee-claim-default-parameters branch from 96eb15c to 3495ca2 Compare June 20, 2024 11:01
agent,common: lower the default parameters for query fee claiming
@chriswessels chriswessels force-pushed the bugra/query-fee-claim-default-parameters branch from 3495ca2 to 76d1c25 Compare June 24, 2024 18:01
Copy link

gitguardian bot commented Jun 27, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12241928 Triggered Generic High Entropy Secret 4891fa9 network-configs/config.yaml View secret
12251296 Triggered Generic High Entropy Secret 4891fa9 network-configs/config.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@fordN fordN closed this Jun 27, 2024
@fordN
Copy link
Contributor

fordN commented Jun 27, 2024

Closed in favor of #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants