indexer-agent: maxAllocationEpochs not being considered when identifiyng expired allocations

[tilacog]

Multiple indexers have reported that the Indexer Agent will close and renew allocations one epoch after creation.

This means that the maxAllocationEpochs value provided by the Staking contract is not being considered when identifying expired allocations during the reconciliation loop.

Requirements

Beta Give feedback

1. The Agent must only close allocations when they are duly expired.
2. For a better indexer experience, add logs that inform how the allocation expiration epoch was calculated: either by an indexing rule, the maxAllocationEpoch value obtained from the Staking contract, or the minimum default of one epoch.

Success Criteria

Beta Give feedback

1. Manual Test: Confirm (on-chain) that allocations are closed N epochs after creation, where N is the expected value for maxAllocationEpochs. (considering governing indexing rules have no value set for allocationLifetime)

[tilacog]

After a thorough review of user feedback suggesting a potential bug, we've found evidence indicating that the Agent is functioning as intended.

Logs show that maxAllocationEpochs value is being correctly fetched from the Staking contracts and being considered in the desired allocation lifetime calculation as designed.

[fordN]

Closing this issue. See comment above for explanation.