Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Leverage SwiftDialog's banner image and title #498

Open
Bearzooka opened this issue Apr 4, 2024 · 2 comments
Open

[FR] Leverage SwiftDialog's banner image and title #498

Bearzooka opened this issue Apr 4, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Bearzooka
Copy link

PLEASE NOTE THAT FEATURE REQUESTS ARE ONLY CONSIDERED AGAINST v.28.0+

Is your feature request related to a problem? Please describe.
Not a problem, just a nice thing to have. I'm using SwiftDialog here and there and now include a nice banner we got from the design team. It would add to the consistency to use that banner as well while using erase-install to update Macs.

Describe the solution you'd like
An additional couple of flags to point to a banner image and define the banner text (which would be used instead of the regular title)

Describe alternatives you've considered
I've considered hardcoding this changes into the existing script, but that would mean I cannot longer use the package as it comes from the releases section.

Additional context
Example of the banner I'm using on other dialogs
image-1

@Bearzooka Bearzooka added the enhancement New feature or request label Apr 4, 2024
@grahampugh
Copy link
Owner

@Bearzooka I don't want to get in the business of providing all sorts of variables for window size and shape, as there are already way too many parameters available but I don't want to move to a level of complexity that requires a json file or config profile such as is needed for things like Setup Your Mac or super.

I'm thinking the problem with offering an option to provide a banner image is that people will want ones of different sizes. I'm also not currently providing any options to customise titles and I don't want to do that either, (1) due to the localizations built in and (2) because as soon as I do that, people will want to be able to change every single dialog.

So the only manageable option I would think of is a fixed-sized banner, with the existing regular titles still used.

@Bearzooka
Copy link
Author

@grahampugh Thanks for your reply.

I totally understand your position and in fact, AFAIK SwiftDialog has that kind of notion, where there's only the --bannerimage flag and it will default size. The only other change is that title becomes bannerText.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants