Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't handle "Alternatives" correctly inside a master playlist's "variants" #191

Open
sjpotter opened this issue Jan 30, 2023 · 0 comments

Comments

@sjpotter
Copy link

From a few cursory tests, it seems it doesn't handle variants correctly in 2 ways..

  1. it only adds the Alternatives to the first media playlist it fills in as a variant.
  2. If the alternatives are at the end of the m3u8, none of them get it.

It would seem the fix would be to only accuulate "alternatives" until the file has been fully parsed, and then to use the accuulated alternatives to each Variant.

Another possible fix would be to simply not include the Alternatives in the Variant, but have them at the same level in the struct as the Variants array.

This assume that "EXT-X-MEDIA" can be really anywhere in the file, its possible that they should always be before the the media playlist reference, but in practce I have seen files that have them at the top and at the bottom. The first issue I saw with the file at the top, while the second issue with them at the bottom)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant