Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor templated event and link generation #28

Merged
merged 10 commits into from
May 29, 2024

Conversation

stoewer
Copy link
Collaborator

@stoewer stoewer commented May 27, 2024

This PR makes the initialization phase and generation phase of events and links more similar to the initialization and generation of resources and spans.

Additionally the PR makes the following changes:

  • Event times now have a random offset
  • Attributes for random events and links now take the cardinality parameter into account
  • The template.js example creates a diverse range of events, exceptions and links
  • Update to the latest Go and golangci-lint version

@stoewer stoewer marked this pull request as ready for review May 28, 2024 01:22
Copy link
Contributor

@zalegrala zalegrala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@stoewer stoewer merged commit c088e8e into grafana:main May 29, 2024
2 checks passed
@stoewer stoewer deleted the refactor-event-and-link-gen branch May 29, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants