Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TLS struct keys and adjust field tags to match field names #27

Merged
merged 9 commits into from
May 23, 2024

Conversation

zalegrala
Copy link
Contributor

The previous update to enable TLS config settings leveraged existing structs which, when mapped from JS -> Golang, did not end up with a friendly user interface. Here we clean up the struct fields after reading the following docs.

https://grafana.com/docs/k6/latest/extensions/explanations/go-js-bridge/#about-the-go-to-js-bridge

Also update the docker examples to match the new struct keys.

Copy link
Collaborator

@stoewer stoewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. Tested it locally and works well.

There is also a configuration example in the README.md where we use the top level insecure: true. It should be changed to:

tls: {
   insecure: true,
}

examples/param/param.js Outdated Show resolved Hide resolved
examples/template/template.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@stoewer stoewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoewer stoewer merged commit 1f223eb into main May 23, 2024
2 checks passed
@stoewer stoewer deleted the tlsCleanup branch May 23, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants