Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resident set memory for the etcd memory alert. #9997

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Use resident set memory for the etcd memory alert. #9997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a1f571
Use resident memory for the etcd memory alert.
seizethedave Nov 22, 2024
5867138
Changelog entry.
seizethedave Nov 22, 2024
668d6fb
Rebuild mixin yamls.
seizethedave Nov 22, 2024
b499db5
And rebuild helm alerts.
seizethedave Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
* [BUGFIX] Alerts: Fix autoscaling metrics joins in `MimirAutoscalerNotActive` when series churn. #9412
* [BUGFIX] Alerts: Exclude failed cache "add" operations from alerting since failures are expected in normal operation. #9658
* [BUGFIX] Alerts: Exclude read-only replicas from `IngesterInstanceHasNoTenants` alert. #9843
* [BUGFIX] Alerts: Use resident set memory for the `EtcdAllocatingTooMuchMemory` alert so that ephemeral file cache memory doesn't cause the alert to misfire. #9997

### Jsonnet

Expand Down
4 changes: 2 additions & 2 deletions ...amonitoring-values-generated/mimir-distributed/templates/metamonitoring/mixin-alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ spec:
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#etcdallocatingtoomuchmemory
expr: |
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.65
Expand All @@ -619,7 +619,7 @@ spec:
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#etcdallocatingtoomuchmemory
expr: |
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.8
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-mixin-compiled-baremetal/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,7 +583,7 @@ groups:
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#etcdallocatingtoomuchmemory
expr: |
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.65
Expand All @@ -597,7 +597,7 @@ groups:
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#etcdallocatingtoomuchmemory
expr: |
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.8
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-mixin-compiled/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -593,7 +593,7 @@ groups:
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#etcdallocatingtoomuchmemory
expr: |
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.65
Expand All @@ -607,7 +607,7 @@ groups:
runbook_url: https://grafana.com/docs/mimir/latest/operators-guide/mimir-runbooks/#etcdallocatingtoomuchmemory
expr: |
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.8
Expand Down
4 changes: 2 additions & 2 deletions operations/mimir-mixin/alerts/alerts.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
alert: 'EtcdAllocatingTooMuchMemory',
expr: |||
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.65
Expand All @@ -894,7 +894,7 @@ local utils = import 'mixin-utils/utils.libsonnet';
alert: 'EtcdAllocatingTooMuchMemory',
expr: |||
(
container_memory_working_set_bytes{container="etcd"}
container_memory_rss{container="etcd"}
/
( container_spec_memory_limit_bytes{container="etcd"} > 0 )
) > 0.8
Expand Down
Loading