[helm] Si bytes calculation always floor fix #10044
Draft
+75
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Changes the computation of
mimir.siToBytesto use floating point arithmetics.Additionally, adding a multiplication factor of
0.9to the store gatewayGOMEMLIMITcalculation. In the issue, it was suggested the multiplication factor to be0.8but after some testing and looking at other projects (such as prometheus) I settled on0.9. Looking at the examples, it is common that the memory request and limit will be different so being a more generous number0.9is probably fine - some would argue a straight translation is probably fine as well which is the case in the jsonnet version. I am not too sure how exactly the jsonnet version works but from what I can tell this change does create a drift on theGOMEMLIMITcalculation.The tests in ci -
compare-helm-with-jsonnet/compare-manifeststo be exact - is failing but I can't get it to work and looking at the other PRs it looks like they have been failing for a while.Which issue(s) this PR fixes or relates to
Fixes #9780
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.