PromQL: Add holt_winters alias

Signed-off-by: Arve Knudsen <[email protected]>
grafana · Nov 7, 2024 · ab952f9 · ab952f9
1 parent 279fac9
commit ab952f9
Show file tree

Hide file tree

Showing 2 changed files with 50 additions and 42 deletions.
diff --git a/promql/functions.go b/promql/functions.go
@@ -1668,48 +1668,50 @@ var FunctionCalls = map[string]FunctionCall{
 	"histogram_stddev":             funcHistogramStdDev,
 	"histogram_stdvar":             funcHistogramStdVar,
 	"double_exponential_smoothing": funcDoubleExponentialSmoothing,
-	"hour":                         funcHour,
-	"idelta":                       funcIdelta,
-	"increase":                     funcIncrease,
-	"info":                         nil,
-	"irate":                        funcIrate,
-	"label_replace":                nil, // evalLabelReplace not called via this map.
-	"label_join":                   nil, // evalLabelJoin not called via this map.
-	"ln":                           funcLn,
-	"log10":                        funcLog10,
-	"log2":                         funcLog2,
-	"last_over_time":               funcLastOverTime,
-	"mad_over_time":                funcMadOverTime,
-	"max_over_time":                funcMaxOverTime,
-	"min_over_time":                funcMinOverTime,
-	"minute":                       funcMinute,
-	"month":                        funcMonth,
-	"pi":                           funcPi,
-	"predict_linear":               funcPredictLinear,
-	"present_over_time":            funcPresentOverTime,
-	"quantile_over_time":           funcQuantileOverTime,
-	"rad":                          funcRad,
-	"rate":                         funcRate,
-	"resets":                       funcResets,
-	"round":                        funcRound,
-	"scalar":                       funcScalar,
-	"sgn":                          funcSgn,
-	"sin":                          funcSin,
-	"sinh":                         funcSinh,
-	"sort":                         funcSort,
-	"sort_desc":                    funcSortDesc,
-	"sort_by_label":                funcSortByLabel,
-	"sort_by_label_desc":           funcSortByLabelDesc,
-	"sqrt":                         funcSqrt,
-	"stddev_over_time":             funcStddevOverTime,
-	"stdvar_over_time":             funcStdvarOverTime,
-	"sum_over_time":                funcSumOverTime,
-	"tan":                          funcTan,
-	"tanh":                         funcTanh,
-	"time":                         funcTime,
-	"timestamp":                    funcTimestamp,
-	"vector":                       funcVector,
-	"year":                         funcYear,
+	// Keep an alias for Mimir users using holt_winters.
+	"holt_winters":       funcDoubleExponentialSmoothing,
+	"hour":               funcHour,
+	"idelta":             funcIdelta,
+	"increase":           funcIncrease,
+	"info":               nil,
+	"irate":              funcIrate,
+	"label_replace":      nil, // evalLabelReplace not called via this map.
+	"label_join":         nil, // evalLabelJoin not called via this map.
+	"ln":                 funcLn,
+	"log10":              funcLog10,
+	"log2":               funcLog2,
+	"last_over_time":     funcLastOverTime,
+	"mad_over_time":      funcMadOverTime,
+	"max_over_time":      funcMaxOverTime,
+	"min_over_time":      funcMinOverTime,
+	"minute":             funcMinute,
+	"month":              funcMonth,
+	"pi":                 funcPi,
+	"predict_linear":     funcPredictLinear,
+	"present_over_time":  funcPresentOverTime,
+	"quantile_over_time": funcQuantileOverTime,
+	"rad":                funcRad,
+	"rate":               funcRate,
+	"resets":             funcResets,
+	"round":              funcRound,
+	"scalar":             funcScalar,
+	"sgn":                funcSgn,
+	"sin":                funcSin,
+	"sinh":               funcSinh,
+	"sort":               funcSort,
+	"sort_desc":          funcSortDesc,
+	"sort_by_label":      funcSortByLabel,
+	"sort_by_label_desc": funcSortByLabelDesc,
+	"sqrt":               funcSqrt,
+	"stddev_over_time":   funcStddevOverTime,
+	"stdvar_over_time":   funcStdvarOverTime,
+	"sum_over_time":      funcSumOverTime,
+	"tan":                funcTan,
+	"tanh":               funcTanh,
+	"time":               funcTime,
+	"timestamp":          funcTimestamp,
+	"vector":             funcVector,
+	"year":               funcYear,
 }
 
 // AtModifierUnsafeFunctions are the functions whose result

diff --git a/promql/parser/functions.go b/promql/parser/functions.go
@@ -208,6 +208,12 @@ var Functions = map[string]*Function{
 		ReturnType:   ValueTypeVector,
 		Experimental: true,
 	},
+	// Keep an alias for Mimir users using holt_winters.
+	"holt_winters": {
+		Name:         "holt_winters",
+		ArgTypes:     []ValueType{ValueTypeMatrix, ValueTypeScalar, ValueTypeScalar},
+		ReturnType:   ValueTypeVector,
+	},
 	"hour": {
 		Name:       "hour",
 		ArgTypes:   []ValueType{ValueTypeVector},