Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the new error types be exported? #117

Open
ziltodian opened this issue Sep 24, 2024 · 5 comments
Open

Can the new error types be exported? #117

ziltodian opened this issue Sep 24, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@ziltodian
Copy link

Hi @oleiade ,

WRT this, thanks for adding the additional error types. However, we're still unable to check for an instance of the new errors as they're not exported. Would it be possible for the new errors to be exported so we can check for an instance of NetworkError?

Thanks

@oleiade
Copy link
Member

oleiade commented Sep 24, 2024

Hey @ziltodian 👋🏻

For sure, we haven't managed to publish a new release yet, but we'll try to get that done as soon as possible. Errors will be exported both from the main index.js file, as well as client-specific ones 🙇🏻

@oleiade oleiade added enhancement New feature or request and removed triage labels Sep 24, 2024
@oleiade
Copy link
Member

oleiade commented Oct 14, 2024

Hi @ziltodian 👋🏻

We have published a new release of jslib-aws (v0.13.0). Error types are now exported from every bundles. Could you give it a spin, and let us know if that addresses the issue for you? 🙇🏻

PS: in order to keep the issue backlog manageable, without answer, I will close this in one week 👍🏻

@ziltodian
Copy link
Author

Hi @oleiade , I've actually made the change to use NetworkError today. It's currently in review. I'll keep you posted.

@ziltodian
Copy link
Author

Hi @oleiade , we've been able to update our code to check for an instance of NetworkError. Many thanks for the changes. Some feedback I have is that it might also be helpful to re-export the NetworkErrorName type and the *ErrorKind enums.

@oleiade
Copy link
Member

oleiade commented Nov 8, 2024

Hi @ziltodian 👋🏻

If you have the capacity to do so, I think that would be a good first issue to make a PR for.

Let me know if you don't and I'll find a moment to adress it myself 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants