Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-operator]: Adds first implementation of tempo-operator helm-chart #3329

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

suyash-811
Copy link

Background:
We were expressing interest in #3032 to create a helm-chart for tempo-operator. I started working on this a while ago, and i have an initial working version of the helm-chart.

I would however like to also get some help on certain open questions, which could help maintaining this chart easier in the future. (Questions listed below)

  1. How should we deal with CRDs? I have included them in the crds folder in the chart. However, often migrating to newer versions of the CRDs could be challenging. Any ideas on how to handle CRDs?
  2. This one would be for someone from the tempo-operator community (I'll link them in the PR later). The deployment contains some environment variables which specify image versions for several services(code block below). Do removing any of these ENV VARs cause the operator to behave differently?
          env:
          - name: RELATED_IMAGE_TEMPO
            value: docker.io/grafana/tempo:2.5.0
          - name: RELATED_IMAGE_TEMPO_QUERY
            value: docker.io/grafana/tempo-query:2.5.0
          - name: RELATED_IMAGE_TEMPO_GATEWAY
            value: quay.io/observatorium/api:main-2024-05-29-ca8d2de
          - name: RELATED_IMAGE_TEMPO_GATEWAY_OPA
            value: quay.io/observatorium/opa-openshift:main-2024-04-29-914c13f
          - name: RELATED_IMAGE_OAUTH_PROXY
            value: quay.io/openshift/origin-oauth-proxy:4.12

Looking forward to suggestions for improvements and collaborating on bringing this to release soon! 😄

(P.S. apologies if i missed out any details. This is my first PR here.)

@suyash-811 suyash-811 requested a review from a team as a code owner September 25, 2024 21:59
@CLAassistant
Copy link

CLAassistant commented Sep 25, 2024

CLA assistant check
All committers have signed the CLA.

suyash-811 and others added 16 commits September 26, 2024 00:09
Signed-off-by: Suyash Sonawane <[email protected]>
Signed-off-by: Suyash S <[email protected]>
Signed-off-by: Suyash Sonawane <[email protected]>
Signed-off-by: Suyash S <[email protected]>
Signed-off-by: Suyash S <[email protected]>
@suyash-811 suyash-811 force-pushed the feat/create-tempo-operator-chart branch from 2868fd8 to 644f8e2 Compare September 25, 2024 22:10
suyash-811 and others added 2 commits September 26, 2024 22:36
Signed-off-by: William Dumont <[email protected]>
Signed-off-by: Suyash S <[email protected]>
@suyash-811 suyash-811 force-pushed the feat/create-tempo-operator-chart branch from e39630c to 369a783 Compare September 26, 2024 20:37
@suyash-811
Copy link
Author

I pushed a commit to fix problems with linting, but pushed without the signoff. Thus, had to rebase with a signoff again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants