Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tempo-distributed] Duplicate label because of referencing bug #3237

Open
eloo-abi opened this issue Jul 23, 2024 · 0 comments · May be fixed by #3451
Open

[tempo-distributed] Duplicate label because of referencing bug #3237

eloo-abi opened this issue Jul 23, 2024 · 0 comments · May be fixed by #3451
Assignees
@SimKev2

Comments

@eloo-abi
Copy link

Hi,

i have found a bug with the podLabels in the ingester sts.

        {{- include "ingester.podLabels" $dict | nindent 8 }}
        {{- with .Values.tempo.podLabels }}
        {{- toYaml . | nindent 8 }}
        {{- end }}
        {{- with .Values.ingester.podLabels }}
        {{- toYaml . | nindent 8 }}
        {{- end }}

here is ingester.podLabels used twice and this causes duplicate keys for labels.

mapping key "my-label" already defined at line ..

helm-charts/charts/tempo-distributed/templates/ingester/statefulset-ingester.yaml

Line 41 in e6ed5e8

{{- include "ingester.podLabels" $dict | nindent 8 }}

according to the compactor as reference it should be

        {{- include "tempo.podLabels" $dict | nindent 8 }}

Best regards
@SimKev2 SimKev2 self-assigned this Nov 25, 2024
@SimKev2 SimKev2 linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SimKev2 SimKev2

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tempo-distributed] Remove duplicated ingester podLabels grafana/helm-charts
2 participants
@SimKev2 @eloo-abi