Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only make types Partial if it's necessary #54

Open
sdboyer opened this issue May 27, 2022 · 0 comments
Open

Only make types Partial if it's necessary #54

sdboyer opened this issue May 27, 2022 · 0 comments
Labels
component/generator help wanted Extra attention is needed kind/feature New feature or request

Comments

@sdboyer
Copy link
Contributor

sdboyer commented May 27, 2022

Currently, the default const cuetsy generates for all interface-kinded translated symbols is unconditionally marked as Partial<>. This was, without question, me cutting what appeared to be a cuttable corner, because AFAICT there's no impact on behavior to doing it unconditionally.

Still, it'd be nice to only generate Partial<> defaults if it's actually necessary to do so. And it shouldn't (?) be terribly difficult, as i think the concept corresponds pretty closely to CUE's IsConcrete().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/generator help wanted Extra attention is needed kind/feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant