-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span status code not indicating as error in the trace UI #809
Comments
The trace panel requires a specific column name to be returned, usually with a specific data type. This structure is defined here: https://grafana.com/docs/grafana/latest/explore/trace-integration/#data-api You can try writing a query that shows the status you want. If you have any suggestions on how to do this consistently from one of the other columns (such as Thanks! |
Hi @nextrevision, I'm closing this as based on the comment from @SpencerTorres above this should have a workaround to provide the correct data schema. Please re-open if this is still a problem for you! |
I'm not sure this is something that should be solved outside of the plugin, mainly because the plugin requires the opentelemetry clickhouse exporter to function. I am using the exporter with no modifications. I think the since clickhouse datasource plugin requires the otel exporter, it should add support for displaying errors that are builtin to the schema. |
I'm sorry, but where is the structure described? How do I know what field names and types the plugin expects for full display? |
What happened:
I'm using the latest version of the OpenTelemetry Clickhouse Exporter and have it integrated with Grafana 10.x using the latest Clickhouse datasource version. I can view the trace, but the error icon/indicator does not appear.
What you expected to happen:
When viewing a trace with spans that are of
STATUS_CODE_ERROR
, I would expect a visual hint.How to reproduce it (as minimally and precisely as possible):
I think what is missing is a SpanAttribute named
error
being explicitly set. Since OpenTelemetry doesn't appear to supporterror
as a SpanAttribute through their SDKs, would it be better to key off of the StatusCode column directly?Screenshots
Below without the indicator:
A query showing the result:
Environment:
The text was updated successfully, but these errors were encountered: