Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong documentation on extraPorts hostPort property #600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

and1truong
Copy link

PR Description

Correct extraPorts hostPort property.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • CHANGELOG.md updated

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@and1truong and1truong changed the title Correct extraPorts hostPort property. Fix wrong documentation on extraPorts hostPort property Apr 18, 2024
Copy link
Member

@tpaschalis tpaschalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that the chart is using both port and hostPort

{{- range $portMap := $values.extraPorts }}
- name: {{ $portMap.name }}
port: {{ $portMap.port }}
targetPort: {{ $portMap.targetPort }}
protocol: {{ coalesce $portMap.protocol "TCP" }}

{{- range $portMap := $values.extraPorts }}
- containerPort: {{ $portMap.targetPort }}
{{- if $portMap.hostPort }}
hostPort: {{ $portMap.hostPort }}
{{- end}}
name: {{ $portMap.name }}
protocol: {{ coalesce $portMap.protocol "TCP" }}

Should this be an addition or should we use the same field in both places here?

@rfratto rfratto added the backport-to-agent PR should be backported to the agent repo. label Apr 23, 2024
@and1truong and1truong force-pushed the fix-helmcharts-extra-ports branch 2 times, most recently from 4e3a293 to f364697 Compare April 29, 2024 22:50
@and1truong and1truong force-pushed the fix-helmcharts-extra-ports branch from f364697 to c9129fb Compare April 29, 2024 22:52
@and1truong
Copy link
Author

Thanks @tpaschalis great catching. I pushed the change.

Copy link
Contributor

This PR has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If you do not have enough time to follow up on this PR or you think it's no longer relevant, consider closing it.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your PR will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-agent PR should be backported to the agent repo. needs-attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants