-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong documentation on extraPorts hostPort property #600
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like that the chart is using both port and hostPort
alloy/operations/helm/charts/alloy/templates/cluster_service.yaml
Lines 25 to 29 in 5af9243
{{- range $portMap := $values.extraPorts }} | |
- name: {{ $portMap.name }} | |
port: {{ $portMap.port }} | |
targetPort: {{ $portMap.targetPort }} | |
protocol: {{ coalesce $portMap.protocol "TCP" }} |
alloy/operations/helm/charts/alloy/templates/containers/_agent.yaml
Lines 42 to 48 in 5af9243
{{- range $portMap := $values.extraPorts }} | |
- containerPort: {{ $portMap.targetPort }} | |
{{- if $portMap.hostPort }} | |
hostPort: {{ $portMap.hostPort }} | |
{{- end}} | |
name: {{ $portMap.name }} | |
protocol: {{ coalesce $portMap.protocol "TCP" }} |
Should this be an addition or should we use the same field in both places here?
4e3a293
to
f364697
Compare
f364697
to
c9129fb
Compare
Thanks @tpaschalis great catching. I pushed the change. |
This PR has not had any activity in the past 30 days, so the |
PR Description
Correct extraPorts hostPort property.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist