-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: OpenTelemetry syslog exporter #2132
Conversation
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
…log.md Co-authored-by: Clayton Cornell <[email protected]>
…log.md Co-authored-by: Clayton Cornell <[email protected]>
… feat/syslog-exporter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor tweaks Otherwise looking good.
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
docs/sources/reference/components/otelcol/otelcol.exporter.syslog.md
Outdated
Show resolved
Hide resolved
…log.md Co-authored-by: Clayton Cornell <[email protected]>
Co-authored-by: Clayton Cornell <[email protected]>
Docs look ok. I guess it over to someone else on the team for a code review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only comment I would have is it would be nice to have live debugging. Might be reasonable to do that in a separate PR though.
I'm happy to look at live debugging support in this PR or immediate followup, either is fine with me. |
Otel exporters don't support live debugging yet. To add it you would need to plug it to the common exporter struct so that all Otel exporters get it. Because it would impact all exporters, it should be in a dedicated PR |
PR Description
Add support for the syslog exporter from OpenTelemetry to Alloy. There are several user requests for this component with varying requirements. The upstream component is in
alpha
stability, but does not appear to be unstable at this point in time.Which issue(s) this PR fixes
#312
Notes to the Reviewer
There is significant data-massaging required to use this component well. I attempted to provide good examples in the docs, but this is definitely a good use case for better docs & task based docs moving forward. If there's anything in the docs that feels insufficient please raise it and I'll address.
PR Checklist