Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OpenTelemetry syslog exporter #2132

Merged
merged 16 commits into from
Nov 25, 2024

Conversation

dehaansa
Copy link
Contributor

PR Description

Add support for the syslog exporter from OpenTelemetry to Alloy. There are several user requests for this component with varying requirements. The upstream component is in alpha stability, but does not appear to be unstable at this point in time.

Which issue(s) this PR fixes

#312

Notes to the Reviewer

There is significant data-massaging required to use this component well. I attempted to provide good examples in the docs, but this is definitely a good use case for better docs & task based docs moving forward. If there's anything in the docs that feels insufficient please raise it and I'll address.

PR Checklist

  • CHANGELOG.md updated
  • Documentation added
  • Tests updated
  • Config converters updated

@dehaansa dehaansa requested review from clayton-cornell and a team as code owners November 19, 2024 20:56
@dehaansa dehaansa changed the title Feat/syslog exporter feat: OpenTelemetry syslog exporter Nov 19, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor tweaks Otherwise looking good.

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Nov 20, 2024
@clayton-cornell
Copy link
Contributor

Docs look ok. I guess it over to someone else on the team for a code review?

Copy link
Collaborator

@mattdurham mattdurham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only comment I would have is it would be nice to have live debugging. Might be reasonable to do that in a separate PR though.

@dehaansa
Copy link
Contributor Author

LGTM, only comment I would have is it would be nice to have live debugging. Might be reasonable to do that in a separate PR though.

I'm happy to look at live debugging support in this PR or immediate followup, either is fine with me.

@wildum
Copy link
Contributor

wildum commented Nov 22, 2024

I'm happy to look at live debugging support in this PR or immediate followup, either is fine with me.

Otel exporters don't support live debugging yet. To add it you would need to plug it to the common exporter struct so that all Otel exporters get it. Because it would impact all exporters, it should be in a dedicated PR

@mattdurham mattdurham merged commit 48f9206 into grafana:main Nov 25, 2024
15 checks passed
@dehaansa dehaansa deleted the feat/syslog-exporter branch November 25, 2024 21:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants