Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse official binaries in homebrew #598

Open
ptodev opened this issue Apr 17, 2024 · 3 comments
Open

Reuse official binaries in homebrew #598

ptodev opened this issue Apr 17, 2024 · 3 comments
Labels
enhancement New feature or request needs-attention proposal A proposal for new functionality.

Comments

@ptodev
Copy link
Contributor

ptodev commented Apr 17, 2024

Request

The homebrew recipe for Alloy is currently building Alloy form source instead of reusing the official binaries from our releases. It would be good to reuse the official binaries - the installation would be faster, and wouldn't require installing things like Go. Maybe it also wouldn't require "node" and "yarn"?

Use case

Faster installations and simpler code.

@ptodev ptodev added the enhancement New feature or request label Apr 17, 2024
@hainenber
Copy link
Contributor

hainenber commented Apr 18, 2024

IIRC, you'll need to perform code signing for Alloy binaries if users want to install it on Mac. I'm not sure if there's already one in place (DEB and RPM packages are signed already)

For now, I think we can selectively reuse official binaries for Linux installation.

@rfratto
Copy link
Member

rfratto commented Apr 18, 2024

I feel like it's against the Homebrew expected patterns to directly download pre-built binaries. IMO we should try to make our Formula feel as native to Homebrew as possible, although that means going through the extra work of automating building bottles for people who don't want to build from source.

Copy link
Contributor

This issue has not had any activity in the past 30 days, so the needs-attention label has been added to it.
If the opened issue is a bug, check to see if a newer release fixed your issue. If it is no longer relevant, please feel free to close this issue.
The needs-attention label signals to maintainers that something has fallen through the cracks. No action is needed by you; your issue will be kept open and you do not have to respond to this comment. The label will be removed the next time this job runs if there is new activity.
Thank you for your contributions!

@rfratto rfratto added the proposal A proposal for new functionality. label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-attention proposal A proposal for new functionality.
Projects
Status: Incoming
Development

No branches or pull requests

3 participants