Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow a certain order when listing blocks and arguments in documentation #338

Open
ptodev opened this issue Oct 6, 2023 · 2 comments
Open
Labels
proposal A proposal for new functionality. type/docs Docs Squad label across all Grafana Labs repos

Comments

@ptodev
Copy link
Contributor

ptodev commented Oct 6, 2023

Background

The document on best practices with writing Flow components should also include guidance on how to order blocks and attributes when listing them in a table. This will help make our documentation more predictable and easier to read.

Proposal

For example, we could propose that:

  • required attributes/blocks should be listed prior to any optional ones.
  • sections about blocks should appear in the same order in which the blocks were listed in the table. E.g. if an annotations block is listed before a filter block in the table, then the ### annotations block section should also appear before the ### filter block section.

It would also be nice if we could also add CI tests for this. But I'm not sure if this is possible.

@ptodev ptodev added proposal A proposal for new functionality. type/docs Docs Squad label across all Grafana Labs repos labels Oct 6, 2023
@tpaschalis
Copy link
Member

I'm on-board with the two suggestions here. Also, maybe we should talk about the specific order within required and optional. Is it alphabetical order, is it up to the component author's discretion to order by usefuleness/frequency of use?

@rfratto rfratto transferred this issue from grafana/agent Apr 11, 2024
@rfratto rfratto moved this to Incoming in Alloy proposals Jun 14, 2024
@clayton-cornell
Copy link
Contributor

clayton-cornell commented Sep 11, 2024

Some drafting (testing ideas and changes) happening in this PR: #1630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for new functionality. type/docs Docs Squad label across all Grafana Labs repos
Projects
Status: Incoming
Development

No branches or pull requests

3 participants