From b3a313eb54c6812b83906fd3d6b64a3f461a1966 Mon Sep 17 00:00:00 2001 From: Cristian Greco Date: Mon, 2 Dec 2024 17:27:03 +0100 Subject: [PATCH] better naming --- .../mysql/collector/query_sample_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/component/database_observability/mysql/collector/query_sample_test.go b/internal/component/database_observability/mysql/collector/query_sample_test.go index 6e37572cc8..770ecda7f6 100644 --- a/internal/component/database_observability/mysql/collector/query_sample_test.go +++ b/internal/component/database_observability/mysql/collector/query_sample_test.go @@ -239,7 +239,7 @@ func TestQuerySample(t *testing.T) { func TestQuerySampleSQLDriverErrors(t *testing.T) { defer goleak.VerifyNone(t) - t.Run("QueryContext() fail", func(t *testing.T) { + t.Run("unrecoverable sql error", func(t *testing.T) { db, mock, err := sqlmock.New(sqlmock.QueryMatcherOption(sqlmock.QueryMatcherEqual)) require.NoError(t, err) defer db.Close() @@ -273,7 +273,7 @@ func TestQuerySampleSQLDriverErrors(t *testing.T) { require.NoError(t, err) }) - t.Run("Scan() fail", func(t *testing.T) { + t.Run("recoverable sql error in result set", func(t *testing.T) { db, mock, err := sqlmock.New(sqlmock.QueryMatcherOption(sqlmock.QueryMatcherEqual)) require.NoError(t, err) defer db.Close()