From 4e3a2931ea7bdd1a2982cdae903106d3cdf70c40 Mon Sep 17 00:00:00 2001 From: Andy Truong Date: Thu, 18 Apr 2024 16:56:00 +1000 Subject: [PATCH] Correct extraPorts hostPort property. --- CHANGELOG.md | 1 + operations/helm/charts/alloy/README.md | 2 +- operations/helm/charts/alloy/templates/cluster_service.yaml | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1b7c5de0b1..9afa27c44c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -32,6 +32,7 @@ Main (unreleased) - Fix an issue on Windows where uninstalling Alloy did not remove it from the Add/Remove programs list. (@rfratto) +- Fix wrong documentation on alloy.extraPorts.hostPort (@and1truong) v1.0.0 (2024-04-09) ------------------- diff --git a/operations/helm/charts/alloy/README.md b/operations/helm/charts/alloy/README.md index 9a67fadf52..f9bcf6133c 100644 --- a/operations/helm/charts/alloy/README.md +++ b/operations/helm/charts/alloy/README.md @@ -174,7 +174,7 @@ Port numbers specified must be 0 < x < 65535. | ChartPort | KubePort | Description | |-----------|----------|-------------| | targetPort | containerPort | Number of port to expose on the pod's IP address. | -| hostPort | hostPort | (Optional) Number of port to expose on the host. Daemonsets taking traffic might find this useful. | +| hosPort | hostPort | (Optional) Number of port to expose on the host. Daemonsets taking traffic might find this useful. | | name | name | If specified, this must be an `IANA_SVC_NAME` and unique within the pod. Each named port in a pod must have a unique name. Name for the port that can be referred to by services. | protocol | protocol | Must be UDP, TCP, or SCTP. Defaults to "TCP". | diff --git a/operations/helm/charts/alloy/templates/cluster_service.yaml b/operations/helm/charts/alloy/templates/cluster_service.yaml index 1bc940b780..d819d670ae 100644 --- a/operations/helm/charts/alloy/templates/cluster_service.yaml +++ b/operations/helm/charts/alloy/templates/cluster_service.yaml @@ -24,7 +24,7 @@ spec: protocol: "TCP" {{- range $portMap := $values.extraPorts }} - name: {{ $portMap.name }} - port: {{ $portMap.port }} + port: {{ $portMap.hostPort }} targetPort: {{ $portMap.targetPort }} protocol: {{ coalesce $portMap.protocol "TCP" }} {{- end }}