improve regexp performance in loki.process: call fmt only if debug …

…is enabled
grafana · Dec 12, 2024 · 3a41957 · 3a41957
1 parent b97d2b6
commit 3a41957
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -52,6 +52,7 @@ Main (unreleased)
 
 - Use a forked `github.com/goccy/go-json` module which reduces the memory consumption of an Alloy instance by 20MB.
   If Alloy is running certain otelcol components, this reduction will not apply. (@ptodev)
+- improve performance in regexp component: call fmt only if debug is enabled (@r0ka)
 
 ### Bugfixes
 

diff --git a/internal/component/loki/process/stages/regex.go b/internal/component/loki/process/stages/regex.go
@@ -112,7 +112,9 @@ func (r *regexStage) Process(labels model.LabelSet, extracted map[string]interfa
 			extracted[name] = match[i]
 		}
 	}
-	level.Debug(r.logger).Log("msg", "extracted data debug in regex stage", "extracted data", fmt.Sprintf("%v", extracted))
+    if level.Debug(r.logger).Enabled() {
+      level.Debug(r.logger).Log("msg", "extracted data debug in regex stage", "extracted data", fmt.Sprintf("%v", extracted))
+    }
 }
 
 // Name implements Stage