Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana Agent Operator - Support creating rules for Loki #3395

Closed
EStork09 opened this issue Mar 30, 2023 · 2 comments · Fixed by #3936
Closed

Grafana Agent Operator - Support creating rules for Loki #3395

EStork09 opened this issue Mar 30, 2023 · 2 comments · Fixed by #3936
Labels
enhancement New feature or request flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@EStork09
Copy link
Contributor

Similar to #1986 and #2604 there is now support to configure Mimir's ruler with rules from the prom-operator CRDs. Could we use the same CRDs to also generate Loki rules as well?
@rfratto
Copy link
Member

rfratto commented Mar 30, 2023

This should definitely be possible, at least as a Flow component in the same style of #2604. It looks like Loki's ruler API is mostly the same, but uses a different endpoint so it wouldn't work out of the box with the existing mimir.rules.kubernetes component.

@rfratto rfratto added enhancement New feature or request type/infrastructure flow Related to Grafana Agent Flow labels Mar 30, 2023
@EStork09
Copy link
Contributor Author

Yeah I almost thought about just basically copying that PR and renaming everything to loki and seeing how far I could get with it before people realized I had no idea what I was actually doing

@EStork09 EStork09 mentioned this issue May 20, 2023
Merged
3 tasks
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Grafana Agent (Public)
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Loki crds EStork09/agent
2 participants
@rfratto @EStork09