Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge app_agent_receiver instance metric endpoints #3149

Open
nabadger opened this issue Mar 2, 2023 · 0 comments
Open

Merge app_agent_receiver instance metric endpoints #3149

nabadger opened this issue Mar 2, 2023 · 0 comments
Labels
app-agent-receiver Related to the app-agent-receiver enhancement New feature or request variant/static Related to Grafana Agent Static.

Comments

@nabadger
Copy link

nabadger commented Mar 2, 2023

Currently, if we have multiple app-agent-receiver endpoints in use, there is a separate /metrics endpoint for each.

With a single endpoint the URL to scrape is:

integrations/app_agent_receiver/metrics

With multiple endpoints in use, the URL is:

integrations/app_agent_receiver/$instanceId/metric

This causes a couple of problems:

  1. It becomes more tricky for the user to scrape these endpoints (since $instanceId) is fairly dynamic. I'm also not sure if this introduces issues around name conventions and url path specs (does it place restrictions on the instance-name?_

  2. The resulting metrics look the same, and there's no instanceId label to differentiate between them.

I believe there is __meta__ labels provided, but I'm not too sure how I can make use of these (running the agents in k8s).

In general, is there a benefit to having separate metrics endpoints?


I'm currently working around any issues here with some relabelling config in my ServiceMonitor to add the extra labels.

@marctc marctc added the app-agent-receiver Related to the app-agent-receiver label Mar 3, 2023
@rfratto rfratto added variant/flow Relatd to Grafana Agent Flow. variant/static Related to Grafana Agent Static. enhancement New feature or request and removed variant/flow Relatd to Grafana Agent Flow. labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app-agent-receiver Related to the app-agent-receiver enhancement New feature or request variant/static Related to Grafana Agent Static.
Projects
No open projects
Development

No branches or pull requests

3 participants