Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podMonitorSelector and podMonitorNamespaceSelector missing from agent-operator.yaml #2079

Open
bootstrap314 opened this issue Aug 27, 2022 · 2 comments
Labels
operator Grafana Agent Operator related type/docs Docs Squad label across all Grafana Labs repos variant/operator Related to Grafana Agent Static Operator.

Comments

@bootstrap314
Copy link

bootstrap314 commented Aug 27, 2022

When setting up the grafana-agent operator using the agent-operator.yaml template, podmonitor resources do not work. The reason they do not work, is missing configuration for podMonitorSelector and podMonitorNamespaceSelector.

Configuring the MetricsInstance as below fixes this issue:

apiVersion: monitoring.grafana.com/v1alpha1
kind: MetricsInstance
metadata:
  labels:
    agent: grafana-agent
  name: grafana-agent-metrics
  namespace: default
spec:
  remoteWrite:
  - basicAuth:
      password:
        key: password
        name: dev-metrics-secret
      username:
        key: username
        name: dev-metrics-secret
    url: https://prometheus-prod-10-prod-us-central-0.grafana.net/api/prom/push
  serviceMonitorNamespaceSelector: {}
  serviceMonitorSelector:
    matchLabels:
      instance: primary
  podMonitorNamespaceSelector: {}
  podMonitorSelector:
    matchLabels:
      instance: primary

Can someone please fix this? This cost my team two days of time, and for some reason was even missed in a ticket we opened with GrafanaCloud support.

@marctc marctc added the operator Grafana Agent Operator related label Aug 29, 2022
@marctc
Copy link
Contributor

marctc commented Aug 31, 2022

@bootstrap314 thanks for reporting this! We will take a look and try to prioritize. Keep an eye on this issue for further updates 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Oct 1, 2022
@marctc marctc added area/docs and removed area/docs stale Issue/PR mark as stale due lack of activity labels Oct 31, 2022
@osg-grafana osg-grafana added type/docs Docs Squad label across all Grafana Labs repos and removed area/docs labels Nov 1, 2022
@rfratto rfratto added the variant/operator Related to Grafana Agent Static Operator. label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator Grafana Agent Operator related type/docs Docs Squad label across all Grafana Labs repos variant/operator Related to Grafana Agent Static Operator.
Projects
No open projects
Status: No status
Development

No branches or pull requests

4 participants