Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator logs agent nodeSelector #1988

Open
invisibl-dev opened this issue Aug 4, 2022 · 3 comments
Open

operator logs agent nodeSelector #1988

invisibl-dev opened this issue Aug 4, 2022 · 3 comments
Labels
enhancement New feature or request operator Grafana Agent Operator related variant/operator Related to Grafana Agent Static Operator.

Comments

@invisibl-dev
Copy link

currently we use nodeSelector as shown below.

apiVersion: monitoring.grafana.com/v1alpha1
kind: GrafanaAgent
metadata:
  name: grafana-agent
spec:
  nodeSelector:
       nodepool1: 'true'

But it gets applied for logs agent DaemonSet as well. => https://github.com/grafana/agent/blob/v0.26.1/pkg/operator/resources_pod_template.go#L252

Would like to disable nodeSelector for logs subsystem Spec.

@rfratto rfratto added the operator Grafana Agent Operator related label Aug 9, 2022
@rfratto
Copy link
Member

rfratto commented Aug 9, 2022

cc @marctc @captncraig

@captncraig
Copy link
Contributor

One workaround for this would be to create multiple GrafanaAgent resources. You can have one for logs without the nodeSelector, and one for metrics with it. Each GrafanaAgent can include just the MetricsInstance or LogsInstance it wants with the appropriate selectors.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2022

This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Oct 2, 2022
@rfratto rfratto added needs-attention An issue or PR has been sitting around and needs attention. and removed stale Issue/PR mark as stale due lack of activity labels Sep 8, 2023
@rfratto rfratto added variant/operator Related to Grafana Agent Static Operator. enhancement New feature or request labels Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request operator Grafana Agent Operator related variant/operator Related to Grafana Agent Static Operator.
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants