Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/user/configuration/traces-config.md contains wrong information about configuring tail_sampling.policies #1809

Open
bartoszbehring-form3 opened this issue Jun 21, 2022 · 0 comments
Labels
type/docs Docs Squad label across all Grafana Labs repos variant/static Related to Grafana Agent Static.

Comments

@bartoszbehring-form3
Copy link

bartoszbehring-form3 commented Jun 21, 2022

Recently we wanted to configure tail sampling policies the agent. We followed the documentation that mentions you should define them in the same way as it is in the Open Telemetry Collector. For example:

tail_sampling:
  policies:
     [
          {
            name: test-policy-1,
            type: always_sample
          }
     ]

It turned out with such configuration the agent was returning following error. After digging out in the Grafana Agent code we figured it out that, we should do it in the following way instead:

tail_sampling:
  policies:
    - always_sample: ""

However I'm not sure if it's just a documentation being wrong or it is the bug in the code and the Grafana Agent would like to follow the Open Telemetry Collector scheme for this field.

@rfratto rfratto added type/docs keepalive Never close from staleness labels Jul 20, 2022
@osg-grafana osg-grafana added type/docs Docs Squad label across all Grafana Labs repos and removed area/docs labels Nov 1, 2022
@rfratto rfratto added needs-attention An issue or PR has been sitting around and needs attention. and removed keepalive Never close from staleness labels Nov 1, 2023
@rfratto rfratto added the variant/static Related to Grafana Agent Static. label Apr 9, 2024
@github-actions github-actions bot removed the needs-attention An issue or PR has been sitting around and needs attention. label Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos variant/static Related to Grafana Agent Static.
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants