From af4fe53fbb0ef97e5e9c2fe510353e1e13f75cab Mon Sep 17 00:00:00 2001 From: Nelson Osacky Date: Wed, 29 Sep 2021 16:32:20 +0200 Subject: [PATCH 1/2] Use same `failOnPassedAfterRetry` on CI and local. Also reduce the number of suggested retries to 2. Ref #113 Signed-off-by: Nelson Osacky --- README.adoc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/README.adoc b/README.adoc index 5503cec5..a1384754 100644 --- a/README.adoc +++ b/README.adoc @@ -44,7 +44,7 @@ Retrying is configured per test task via the `retry` extension added to each tas ---- test { retry { - maxRetries = 3 + maxRetries = 2 maxFailures = 20 failOnPassedAfterRetry = true } @@ -57,7 +57,7 @@ test { ---- test { retry { - maxRetries.set(3) + maxRetries.set(2) maxFailures.set(20) failOnPassedAfterRetry.set(true) } @@ -75,11 +75,11 @@ boolean isCiServer = System.getenv().containsKey("CI") test { if (isCiServer) { retry { - maxRetries = 3 + maxRetries = 2 maxFailures = 20 - failOnPassedAfterRetry = true } } + failOnPassedAfterRetry = true } ---- From e5a6ccc270b66df8f60e92d701d1b95c95dbdfec Mon Sep 17 00:00:00 2001 From: Nelson Osacky Date: Wed, 29 Sep 2021 16:51:02 +0200 Subject: [PATCH 2/2] set `failOnPassedAfterRetry` inside `retry` block Signed-off-by: Nelson Osacky --- README.adoc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.adoc b/README.adoc index a1384754..8f1ccb2a 100644 --- a/README.adoc +++ b/README.adoc @@ -73,13 +73,13 @@ You may find that local developer builds do not benefit much from retry behaviou ---- boolean isCiServer = System.getenv().containsKey("CI") test { - if (isCiServer) { - retry { + retry { + if (isCiServer) { maxRetries = 2 maxFailures = 20 } + failOnPassedAfterRetry = true } - failOnPassedAfterRetry = true } ----